Skip to content

Input Interaction: always expand single line selection vertically#14487

Merged
ellatrix merged 2 commits intomasterfrom
try/always-expand-single-line-select
Mar 22, 2019
Merged

Input Interaction: always expand single line selection vertically#14487
ellatrix merged 2 commits intomasterfrom
try/always-expand-single-line-select

Conversation

@ellatrix
Copy link
Copy Markdown
Member

@ellatrix ellatrix commented Mar 18, 2019

Description

Fixes #14463. When having a selection that spans over one single line, shift + vertical arrow should always expand the (block) selection, regardless of the direction of the selection.

I'll see if I can make an e2e test for it. Done.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Input Interaction: Shift+ArrowUp uncollapsed single-line selection should expand upward

2 participants