Skip to content

E2E Test Utils: Add missing babel/runtime dependency#14374

Merged
aduth merged 1 commit intomasterfrom
add/e2e-test-utils-babel-runtime-dep
Mar 11, 2019
Merged

E2E Test Utils: Add missing babel/runtime dependency#14374
aduth merged 1 commit intomasterfrom
add/e2e-test-utils-babel-runtime-dep

Conversation

@aduth
Copy link
Copy Markdown
Member

@aduth aduth commented Mar 11, 2019

Related: #14373

This pull request seeks to add a missing dependency on @babel/runtime to the e2e-test-utils package. See #14373 for additional context on why this is necessary:

Each package transpiled using Babel is configured to apply the Babel runtime transform (source). Thus, the built output for any package is expected to contain references to the @babel/runtime module. For this reason, the package must explicitly define @babel/runtime as a dependency.

cc @blowery

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gziolo gziolo gziolo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

No one assigned

Labels

npm Packages Related to npm packages [Tool] E2E Test Utils /packages/e2e-test-utils [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

5.3 (Gutenberg)

Development

Successfully merging this pull request may close these issues.

2 participants

@aduth @gziolo