Webpack: remove TinyMCE external dependency mapping#13971
Merged
Conversation
ellatrix
requested review from
aduth,
ajitbohra,
chrisvanpatten,
gziolo,
mkaz,
notnownikki,
oandregal,
talldan and
youknowriad
as code owners
gziolo
approved these changes
Feb 20, 2019
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Looks good, thanks for cleaning it up 👍
youknowriad
reviewed
Feb 20, 2019
| const externals = { | ||
| react: 'React', | ||
| 'react-dom': 'ReactDOM', | ||
| tinymce: 'tinymce', |
Contributor
There was a problem hiding this comment.
Don't we use this in the classic block?
Member
Author
There was a problem hiding this comment.
No, it directly uses the window global.
Contributor
There was a problem hiding this comment.
Ok that's fine for me.
Member
Author
|
Thanks! |
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is no longer used. Additionally removes an old irrelevant comment.
How has this been tested?
Screenshots
Types of changes
Checklist: