RichText: remove obsolete rule from stylesheet#13871
Merged
Conversation
ellatrix
requested review from
aduth,
ajitbohra,
gziolo,
jorgefilipecosta,
nerrad,
ntwb,
oandregal,
talldan and
youknowriad
as code owners
ellatrix
changed the title
ellatrix
force-pushed
the
fix/rich-text-styles
branch
from
c1d2f03 to
59f1ef0
Compare
jorgefilipecosta
approved these changes
Feb 14, 2019
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
LGTM 👍
I verified empty rich texts contain <br data-rich-text-padding="true"> so this rule is never used as described.
jorgefilipecosta
added
[Type] Enhancement
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This was referenced Apr 30, 2020
This was referenced May 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
p:emptyrule. There's no way it can ever be empty. It's always padded with a<br>element. I believe this is a remnant from the early TinyMCE days when we didn't have a rich text state yet. There would be cases were TinyMCE wouldn't pad with a<br>element. Now this is impossible.How has this been tested?
Screenshots
Types of changes
Checklist: