Skip to content

Remove the limit of 3 keywords for the block registration#13848

Merged
gziolo merged 3 commits intomasterfrom
pr/11953
Feb 13, 2019
Merged

Remove the limit of 3 keywords for the block registration#13848
gziolo merged 3 commits intomasterfrom
pr/11953

Conversation

@gziolo
Copy link
Copy Markdown
Member

@gziolo gziolo commented Feb 13, 2019

Description

Opened to rebase and close #11953. All work was done by @jameelmoses.

Fixes: #11949
Instead of failing to register a block if more than 3 keywords are given, only return the first 3 by slicing the keywords array.

How has this been tested?

npm run lint

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo changed the title Pr/11953 Remove the limit of 3 keywords for the block registration Feb 13, 2019
@gziolo gziolo added this to the 5.1 (Gutenberg) milestone Feb 13, 2019
@gziolo gziolo added [Feature] Block API API that allows to express the block paradigm. [Type] Enhancement A suggestion for improvement. labels Feb 13, 2019
@gziolo gziolo mentioned this pull request Feb 13, 2019
Closed
4 tasks
@gziolo
Copy link
Copy Markdown
Member Author

gziolo commented Feb 13, 2019

#11953 was ✅ by @aduth and myself. Merging based on that.

@gziolo gziolo merged commit 26e3255 into master Feb 13, 2019
@gziolo gziolo deleted the pr/11953 branch February 13, 2019 08:37
This was referenced Feb 13, 2019
Closed
Open
Closed
This was referenced Feb 18, 2019
Merged
Merged
@bluefuton bluefuton mentioned this pull request Feb 27, 2019
Closed
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@gziolo @youknowriad
Remove the limit of 3 keywords for the block registration (#13848)
ffcf4eb 
* Fixes #11949: Error: The block "xxx" can have a maximum of 3 keywords.

* Fixes #11949: Error: The block "xxx" can have a maximum of 3 keywords.

* Fixes #11949: Error: The block xxx can have a maximum of 3 keywords.
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@gziolo @youknowriad
Remove the limit of 3 keywords for the block registration (#13848)
0768884 
* Fixes #11949: Error: The block "xxx" can have a maximum of 3 keywords.

* Fixes #11949: Error: The block "xxx" can have a maximum of 3 keywords.

* Fixes #11949: Error: The block xxx can have a maximum of 3 keywords.
@jsnmoon jsnmoon mentioned this pull request Mar 28, 2019
Closed
@hacknug
Copy link
Copy Markdown

hacknug commented Sep 25, 2019

@gziolo why was this undocumented when it's still something that applies? Docs should be clear about it, no?

Also, why the hard limit? Couldn't find anything about the reasoning behind this limitation. Asking just for curiosity, not sure I'd ever need more than three keywords when I can have more than one in each string.

@gziolo
Copy link
Copy Markdown
Member Author

gziolo commented Sep 25, 2019

There is no limit anymore.

@hacknug
Copy link
Copy Markdown

hacknug commented Sep 26, 2019

But only the first three keywords are used when searching for a block. Am I missing something?

@gziolo
Copy link
Copy Markdown
Member Author

gziolo commented Sep 26, 2019

But only the first three keywords are used when searching for a block. Am I missing something?

Can you reproduce it?

Looking at code, I can't find any logic which would ignore any keywords:

gutenberg/packages/block-editor/src/store/selectors.js

Line 1193 in fd7f27b

keywords: blockType.keywords,

gutenberg/packages/block-editor/src/components/inserter/menu.js

Line 71 in fd7f27b

return matchSearch( item.title ) || some( item.keywords, matchSearch ) || ( itemCategory && matchSearch( itemCategory.title ) );

@hacknug
Copy link
Copy Markdown

hacknug commented Sep 26, 2019

You're right. I've just tested with a couple blocks I built from scratch and it definitely shows up. Issue was with ACF blocks so it might be something on their side. I'll look into it and follow up there. Sorry for the trouble ❤️

@gziolo
Copy link
Copy Markdown
Member Author

gziolo commented Sep 26, 2019

You're right. I've just tested with a couple blocks I built from scratch and it definitely shows up. Issue was with ACF blocks so it might be something on their side. I'll look into it and follow up there. Sorry for the trouble ❤️

It's totally fine. Thank you for testing with custom blocks 👍

@hacknug hacknug mentioned this pull request Sep 27, 2019
Closed
@marekhrabe marekhrabe mentioned this pull request Feb 13, 2020
Merged
This was referenced Apr 30, 2020
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Closed
@juanmaguitar juanmaguitar mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduth aduth Awaiting requested review from aduth

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@mkaz mkaz Awaiting requested review from mkaz

@noisysocks noisysocks Awaiting requested review from noisysocks

@oandregal oandregal Awaiting requested review from oandregal

@notnownikki notnownikki Awaiting requested review from notnownikki

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

No one assigned

Labels

[Feature] Block API API that allows to express the block paradigm. [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

5.1 (Gutenberg)

Development

Successfully merging this pull request may close these issues.

Error: The block "xxx" can have a maximum of 3 keywords.

3 participants

@gziolo @hacknug @jameelmoses