Change deasync to its latest version#13839
Conversation
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Thanks for your first PR :) I left some comments.
.gitignore
Outdated
| yarn.lock | ||
| docker-compose.override.yml | ||
| /wordpress | ||
| /nbproject/* No newline at end of file |
There was a problem hiding this comment.
Any reason for the change here?
There was a problem hiding this comment.
I'm using netbeans and this IDE puts its project configurations in this folder directly in the project. For me it is useful if I want to branch / switch easily without commit this folder.
There was a problem hiding this comment.
I see, in that case, I suggest using the global gitignore instead of adding this to all the projects you work on https://gist.github.com/subfuzion/db7f57fff2fb6998a16c
There was a problem hiding this comment.
Hum, thanks I'm doing and testing it.
It's useful for all my projects :-)
There was a problem hiding this comment.
It's done. It works and I also removed this folder from .gitignore file
There was a problem hiding this comment.
Can you restore the .gitignore file to its original version (it shouldn't appear in the changes)
There was a problem hiding this comment.
Done ! It's due to line feed. Very strange because editorconfig is well configured.
| "sprintf-js": "1.1.1", | ||
| "stylelint-config-wordpress": "13.1.0", | ||
| "uuid": "3.3.2", | ||
| "webpack-bundle-analyzer": "3.0.2", |
There was a problem hiding this comment.
After the change here, I expect at least a small change in the package-lock.json file. (That's why the tests are failing). You should run npm install and commit the package lock.
There was a problem hiding this comment.
Hum ok. I understand now why package-lock.json is needed :)
I just didn't commit this file. I'm going to do it.
|
Congrats for the first PR :) |
2 participants
Fix #13437
Description
npm install deasync@latest --save-dev
How has this been tested?
Environment