Gallery: translate string, not results of sprintf#13830
Merged
gziolo merged 1 commit intoWordPress:masterfrom Feb 13, 2019
simison:patch-2
Merged
Gallery: translate string, not results of sprintf#13830gziolo merged 1 commit intoWordPress:masterfrom simison:patch-2
gziolo merged 1 commit intoWordPress:masterfrom
simison:patch-2
Conversation
simison
requested review from
Soean,
ajitbohra,
gziolo,
jorgefilipecosta,
noisysocks,
notnownikki,
talldan and
youknowriad
as code owners
youknowriad
added
the
Good First Review
gziolo
added
the
Internationalization (i18n)
ocean90
approved these changes
Feb 12, 2019
Member
|
Nice catch, thanks! |
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This was referenced Apr 30, 2020
This was referenced May 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Translation function was previously wrapping results of
sprintf, instead of the string passed tosprinf.How has this been tested?
aria-label="image 1 of 2 in gallery"etc)Checklist: