Check if thumbnail_url is set in getPhotoHtml#13825
Merged
youknowriad merged 1 commit intoWordPress:masterfrom Feb 12, 2019
spacedmonkey:fix/getPhotoHtml
Merged
Check if thumbnail_url is set in getPhotoHtml#13825youknowriad merged 1 commit intoWordPress:masterfrom spacedmonkey:fix/getPhotoHtml
youknowriad merged 1 commit intoWordPress:masterfrom
spacedmonkey:fix/getPhotoHtml
Conversation
spacedmonkey
requested review from
Soean,
ajitbohra,
gziolo,
jorgefilipecosta,
noisysocks,
notnownikki,
talldan and
youknowriad
as code owners
thumbnail_url is an optional field in oembed endpoints. Check it is set first before using and fallback to url if not.
notnownikki
approved these changes
Feb 12, 2019
Member
notnownikki
left a comment
notnownikki
left a comment
There was a problem hiding this comment.
Thank you, this fixes giphy and makes photo handling work as it should.
Contributor
|
Congrats for the first contribution @spacedmonkey |
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
thumbnail_url is an optional field in oembed endpoints. Check it is set first before using and fallback to url if not.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
thumbnail_url is an optional field in oembed endpoints. Check it is set first before using and fallback to url if not.
This was referenced Apr 30, 2020
This was referenced May 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thumbnail_url is an optional field in oembed endpoints. Check it is set first before using and fallback to url if not.
More details can be found in #13426
Checklist: