Fix: Impossible to set empty array on editor-font-sizes.#13824
Merged
jorgefilipecosta merged 1 commit intomasterfrom Feb 12, 2019
Merged
Conversation
jorgefilipecosta
requested review from
aduth,
gziolo and
youknowriad
as code owners
jorgefilipecosta
added
[Type] Bug
chrisvanpatten
approved these changes
Feb 11, 2019
Contributor
chrisvanpatten
left a comment
chrisvanpatten
left a comment
There was a problem hiding this comment.
Looks good to me; excited for more font size improvements to land :)
jorgefilipecosta
deleted the
fix/allow-setting-empty-array-on-font-sizes-is-impossible
branch
This was referenced Feb 18, 2019
Member
|
@jorgefilipecosta Is there an associated core Trac issue I can follow for applying the fix to core? |
Member
Author
|
Hi @aduth, I'm sorry I missed the pings, I added a core patch in https://core.trac.wordpress.org/ticket/46290. |
Member
|
Thanks @jorgefilipecosta 👍 |
5 tasks
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
Closed
This was referenced Apr 30, 2020
This was referenced May 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When setting an empty array on editor-font-sizes nothing happens, and the default font-sizes are used.
This PR's fixes the problem and makes sure that when
add_theme_support('editor-color-palette', array());is added no available font sizes appear in the font size picker. This PR uses the same approach used in colors and makes the behavior consistent with what happens when an empty array is set on editor-color-palette.This change needs to be ported into core.
How has this been tested?
I changed the default font sizes of twenty nineteen theme to:
I verified no default font sizes appear on the editor and just the custom size picker is available.