Conversation
nerrad
added
[Type] Bug
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
It would be good to add a unit test 🤷♂️
Hmm ya, I guess it would :) lemme see if I can write one that catches the bug. |
|
Added a unit test that fails without the fix in this branch and passes with the fix in this branch. |
| } ); | ||
|
|
||
| it( 'does not recurse when action like object returns from a sync ' + | ||
| 'control', () => { |
There was a problem hiding this comment.
Is the concatenation here something automated? Or are you especially strict with line length? 😄
I don't have any strong feelings on it, but it made it slightly more difficult for me to read the test case (or at least, it came as a surprise to me in reading the label).
There was a problem hiding this comment.
Strict with line length. It's a habit I've gotten into in other projects I've worked on but I'm happy to change if its an issue.
There was a problem hiding this comment.
Of the various options I've played around with for handling line length issues, this is the one I've landed on as the one I can be most consistent with and also indents nicely.
There was a problem hiding this comment.
Oh, I can appreciate it. I'm of a similar obsession, particularly for comments, even to the point of enabling the visual "line" for my editor.
I didn't intend to make a thing of it. My only worry might be that the indentation implies that it's of a similar level as the body of the callback, when in fact it's still part of the earlier (it) level.
There was a problem hiding this comment.
I'm of a similar obsession, particularly for comments, even to the point of enabling the visual "line" for my editor.
Heh! I do the same in my IDE + have my IDE configured to show me when line length is exceeded.
3 participants
Description
While working on #13716 I discovered a bug where when a control returns the results with an object that has a
typeproperty,redux-routinewas recursing into that returned object treating it as an action.When I brought this up in slack, @youknowriad suggested it could be a bug in
redux-routineand I tried his suggested fix and that seemed to work so this is the pull applying it.How has this been tested?
Types of changes
As far as I can tell, this is a non-breaking change.
Checklist: