Fixed Component URLInput not honouring className#13800
Merged
noisysocks merged 2 commits intoWordPress:masterfrom Feb 14, 2019
Merged
Fixed Component URLInput not honouring className#13800noisysocks merged 2 commits intoWordPress:masterfrom
noisysocks merged 2 commits intoWordPress:masterfrom
Conversation
Related: WordPress#13754 This pull request fixes the URIInput Component not honouring. This add the className to the parent div for the component
ashwin-pc
requested review from
gziolo,
noisysocks,
talldan and
youknowriad
as code owners
gziolo
added
[Type] Enhancement
noisysocks
requested changes
Feb 11, 2019
Member
noisysocks
left a comment
noisysocks
left a comment
There was a problem hiding this comment.
This looks good to me!
Could you please add className to the documentation in editor/src/components/url-input/README.md?
Contributor
Author
The Readme has been updated to reflect the change |
noisysocks
approved these changes
Feb 14, 2019
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Fixed Component URLInput not honouring className Related: #13754 This pull request fixes the URIInput Component not honouring. This add the className to the parent div for the component * Updated URLInput Readme for className prop
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Fixed Component URLInput not honouring className Related: #13754 This pull request fixes the URIInput Component not honouring. This add the className to the parent div for the component * Updated URLInput Readme for className prop
This was referenced Apr 30, 2020
This was referenced May 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #13754
This pull request fixes the URIInput Component not honouring. This add the className to the parent div for the component
How has this been tested?
Before Change:
The class was not appended to the URLInput class "editor-url-input"
After Change
The class was appended to the URLInput class "editor-url-input"
Types of changes]
Bug fix (non-breaking change which fixes an issue)
Checklist: