Mobile: Implementing Clear All Settings button on Image Settings#13753
Merged
Mobile: Implementing Clear All Settings button on Image Settings#13753
Clear All Settings button on Image Settings#13753Conversation
etoledom
added
the
Mobile App - i.e. Android or iOS
This was referenced Feb 7, 2019
Merged
etoledom
changed the title
Reset to Original button on Image SettingsClear All Settings button on Image Settings
hypest
reviewed
Feb 12, 2019
Contributor
Author
|
Thank you! |
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
…13753) * Mobile: Implementing `Reset to Original` button on Image Settings * Mobile: Change `Revert to Origin` button title to 'Clear All Settings' * Mobile Image block: Changed method name to `onClearSettings` for clarity
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
…13753) * Mobile: Implementing `Reset to Original` button on Image Settings * Mobile: Change `Revert to Origin` button title to 'Clear All Settings' * Mobile Image block: Changed method name to `onClearSettings` for clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a small PR that implements the functionality of the
Revert to OriginalClear All Settingsbutton.As discussed with Thomas, this button should revert all the editable attributes to their default as when the block is created.
Don't worry about the Image Size option, this will be removed here: Mobile: Remove size settings #13750(Merged)To test:
gutenberg-mobilebranch and run the app.Revert to Original.