RichText Readme - Adding missing props to save function inside ES5 Example #13752
Merged
gziolo merged 2 commits intoWordPress:masterfrom Feb 8, 2019
fabiankaegy:master
Merged
RichText Readme - Adding missing props to save function inside ES5 Example #13752gziolo merged 2 commits intoWordPress:masterfrom fabiankaegy:master
gziolo merged 2 commits intoWordPress:masterfrom
fabiankaegy:master
Conversation
In the ES5 example for the RichText component the props are not passed into the save function. Inside the save function they are called though.
merge master back into fork
fabiankaegy
requested review from
aduth,
ellatrix,
gziolo,
jorgefilipecosta and
youknowriad
as code owners
gziolo
approved these changes
Feb 8, 2019
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Good catch, thank you for sending this pull request 👍
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
In the ES5 example for the RichText component the props are not passed into the save function. Inside the save function they are called though.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
In the ES5 example for the RichText component the props are not passed into the save function. Inside the save function they are called though.
This was referenced Apr 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've added missing props to the save function inside the readme es5 example of the RichText component.
How has this been tested?
Change only affect the documentation
Types of changes
Change only affect the documentation
Checklist: