Skip to content

Switch a bunch of documentation titles to title case#13714

Merged
danielbachhuber merged 8 commits intomasterfrom
title-case-docs
Feb 7, 2019
Merged

Switch a bunch of documentation titles to title case#13714
danielbachhuber merged 8 commits intomasterfrom
title-case-docs

Conversation

@danielbachhuber
Copy link
Copy Markdown
Member

@danielbachhuber danielbachhuber commented Feb 7, 2019

No description provided.

@danielbachhuber danielbachhuber added [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers labels Feb 7, 2019
@mkaz
Copy link
Copy Markdown
Member

mkaz commented Feb 7, 2019

I honestly don't know what should be the preferred style.

Randomly looking through other documentation I see both, just one example here:
https://make.wordpress.org/core/handbook/best-practices/when-you-become-a-committer/

gziolo
gziolo approved these changes Feb 7, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this patch, let's start moving toward title case to solve the issue 🚀

@gziolo gziolo added this to the Documentation & Handbook milestone Feb 7, 2019
@danielbachhuber
Copy link
Copy Markdown
Member Author

danielbachhuber commented Feb 7, 2019

@gziolo Any ideas on why the build is failing with this?

image

@danielbachhuber
Copy link
Copy Markdown
Member Author

danielbachhuber commented Feb 7, 2019

@gziolo Any ideas on why the build is failing with this?

Nevermind, I've found the issue.

@chrisvanpatten
Copy link
Copy Markdown
Contributor

chrisvanpatten commented Feb 7, 2019

@danielbachhuber The docs manifest needs to be updated; it contains the doc titles which are extracted from the markdown. npm run docs:build locally and it should update docs/manifest.json for you.

@danielbachhuber
Copy link
Copy Markdown
Member Author

danielbachhuber commented Feb 7, 2019

@danielbachhuber The docs manifest needs to be updated

Yep, done in 8c5220b

chrisvanpatten
chrisvanpatten approved these changes Feb 7, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@chrisvanpatten chrisvanpatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes; good to go after that!

@danielbachhuber danielbachhuber merged commit dafd700 into master Feb 7, 2019
@danielbachhuber danielbachhuber deleted the title-case-docs branch February 7, 2019 15:38
This was referenced Feb 18, 2019
Merged
Merged
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@danielbachhuber @youknowriad
Switch a bunch of documentation titles to title case (#13714)
31a8581 
* Switch a bunch of documentation titles to title case

* Fix one lingering instance

* Update `manifest.json` with new titles

* Fix merge conflict discrepancy

* npm should always be lowercase

Co-Authored-By: danielbachhuber <[email protected]>

* Correct spelling for JavaScript

Co-Authored-By: danielbachhuber <[email protected]>

* Update `manifest.json` again
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@danielbachhuber @youknowriad
Switch a bunch of documentation titles to title case (#13714)
813806c 
* Switch a bunch of documentation titles to title case

* Fix one lingering instance

* Update `manifest.json` with new titles

* Fix merge conflict discrepancy

* npm should always be lowercase

Co-Authored-By: danielbachhuber <[email protected]>

* Correct spelling for JavaScript

Co-Authored-By: danielbachhuber <[email protected]>

* Update `manifest.json` again
This was referenced Apr 30, 2020
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gziolo gziolo gziolo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@mkaz mkaz Awaiting requested review from mkaz

@oandregal oandregal Awaiting requested review from oandregal

@youknowriad youknowriad Awaiting requested review from youknowriad

@notnownikki notnownikki Awaiting requested review from notnownikki

+1 more reviewer

@chrisvanpatten chrisvanpatten chrisvanpatten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers

Projects

None yet

Milestone

Documentation & Handbook

Development

Successfully merging this pull request may close these issues.

4 participants

@danielbachhuber @mkaz @chrisvanpatten @gziolo