Mobile: Implemented media options sheet#13656
Merged
Conversation
jorgefilipecosta
added
the
Mobile App - i.e. Android or iOS
jorgefilipecosta
changed the title
Contributor
|
Why do we only show the |
| { __( 'Image' ) } | ||
| </Text> | ||
| <Text style={ styles.emptyStateDescription }> | ||
| { __( 'UPLOAD IMAGE' ) } |
Contributor
There was a problem hiding this comment.
Maybe change this string to: "Select Image" ?
Contributor
Author
There was a problem hiding this comment.
Hey @SergioEstevao , thanks for the comment.
You are right. I will fix that.
etoledom
reviewed
Feb 5, 2019
Contributor
etoledom
left a comment
etoledom
left a comment
There was a problem hiding this comment.
Thank you for this PR @marecar3 !
I agree with @SergioEstevao that the button title should not be Upload since we are not always uploading images (i.e. WP Media Library).
Do we need extra work to apply these changes to WPiOS? The buttons are not working there.
I left one code comment with a small issue, but the rest looks good. 👍
marecar3
requested review from
daniloercoli,
diegoreymendez,
gziolo,
hypest,
koke,
mzorz,
oandregal,
pinarol and
youknowriad
as code owners
Contributor
|
Working great now on iOS! |
SergioEstevao
approved these changes
Feb 8, 2019
Contributor
SergioEstevao
left a comment
SergioEstevao
left a comment
There was a problem hiding this comment.
Working great now on iOS!
# Conflicts: # packages/block-library/src/image/edit.native.js
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Implemented media options sheet
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Implemented media options sheet
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced media options sheet based on Bottom sheet component.
Test : Gutenberg mobile PR : wordpress-mobile/gutenberg-mobile#539