Conversation
|
I don't feel strongly but was thinking maybe we should get rid of all the vendors handling from the plugin now that the minimum version is 5.0. If we need to update one of these, we could override the script like we do for the packages, but otherwise it's not necessary to maintain in the plugin anymore. what do you think? cc @aduth as you're working on the PHP removals. |
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
It looks like something that was missed down the road.
|
I'm sure we will have to override React pretty soon to start using hooks. Saying that I think we should remove all overrides but leave the room to be able to do so in the near future. Maybe, we simply wait for React 16.8 and bump it for plugin and remove all overrides at the same time :) |
See #13573 |
|
FYI, Core uses [email protected], which was already (and still) different from what we use in Gutenberg. |
…rnmobile/372-use-RichText-on-Title-block * 'master' of https://github.com/WordPress/gutenberg: (22 commits) Make the modal title styling consistent (#13669) Disable navigation block for text mode. (#12185) Fix: Linting problem in modal example code (#13671) Add myself as a code owner to the annotations (#13672) Add more reviewers to CODEOWNERS.md file (#13667) Plugin: Remove jQuery heartbeat-to-hooks proxying (#13576) Workflow: Add repository CODEOWNERS file (#13604) Add a mobile minimum size for form fields (#13639) Update edit-save documentation (#13578) Alt image setting (#13631) Fix: Allow years lower than 1970 in DateTime component. (#13602) Using addQueryArgs to generate Manage All Reusable Blocks link (#13653) Bump plugin version to 5.0.0-rc.1 (#13652) Update lodash to 4.17.10 (#13651) Refreshed PR (#9469) Set default values of the width and height input fields according to the actual image dimensions (#7687) 12647 fix css color picker (#12747) Remove "we" from messages (#13644) Fix: Font size picker max width on mobile (#13264) Fix/issue 12501 menu item aria label ...
4 participants
Description
Requesting lodash 4.17.5 from unpkg was systematically failing making building the zip of the plugin impossible.
Requesting 4.17.10 was working perfectly fine. There are many references to 4.17.10 across our packages so I think it is fine to update the version downloaded from unpkg.
Meanwhile after many tries to download https://unpkg.com/[email protected]/lodash.min.js and getting error 500, it started working.
I guess older versions are not widely distributed in the CDN and this update is an improvement to avoid problems while building the zip in the future.
How has this been tested?
I checked Gutenberg works normally (smoke testing).
I checked building Gutenberg zip works correctly
./bin/build-plugin-zip.shI checked I can download https://unpkg.com/[email protected]/lodash.min.js without any problem.