Plugin: Populate demo content by default content filters#13553
Merged
Conversation
Assumed to be called only in the process of generating a new post for edit (the same assumption checked by testing 'auto-draft' status)
aduth
added
the
Gutenberg Plugin
youknowriad
approved these changes
Jan 29, 2019
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Works well on my testing 👍
daniloercoli
added a commit
that referenced
this pull request
Jan 30, 2019
…rnmobile/372-use-RichText-on-Title-block * 'master' of https://github.com/WordPress/gutenberg: (36 commits) Fixes plural messages POT generation. (#13577) Typo fix (#13595) REST API: Remove oEmbed proxy HTML filtering (#13575) Removed unnecessary className attribute. Fixes #11664 (#11831) Add changelog for RSS block (#13588) Components: Set type=button for TabPanel button elements. (#11944) Update util.js (#13582) Docs: Add accessbility specific page (#13169) Rnmobile/media methods refactor (#13554) chore(release): publish chore(release): publish Plugin: Deprecate gutenberg_get_script_polyfill (#13536) Block API: Parse entity only when valid character reference (#13512) RichText: List: fix indentation (#13563) Plugin: Deprecate window._wpLoadGutenbergEditor (#13547) Plugin: Avoid setting generic "Edit Post" title on load (#13552) Plugin: Populate demo content by default content filters (#13553) RichText: List: Fix getParentIndex (#13562) RichText: List: Fix outdent with children (#13559) Scripts: Remove npm run build from test-e2e default run (#13420) ...
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Plugin: Populate demo content by default content filters * Plugin: Avoid checking post status on default content Assumed to be called only in the process of generating a new post for edit (the same assumption checked by testing 'auto-draft' status) * Plugin: Remove unreachable initial_edits code
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Plugin: Populate demo content by default content filters * Plugin: Avoid checking post status on default content Assumed to be called only in the process of generating a new post for edit (the same assumption checked by testing 'auto-draft' status) * Plugin: Remove unreachable initial_edits code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request seeks to move handling of the demo content initialization from
gutenberg_editor_scripts_and_stylesto separate filter handlers in a new file dedicated for demo supports (one of the few PHP extensions Gutenberg will offer atop core from the initial 5.0 release). The reason for this change is to facilitate the removal ofgutenberg_editor_scripts_and_styles. Core doesn't otherwise allow for filtering of the$initial_editsit generates for editor initialization, but these can be alternatively provided through thedefault_contentanddefault_titlefilters run byget_default_post_to_edit(the function responsible for generating a new post to edit).Testing instructions:
Verify that the Gutenberg demo content is shown for a new post created via Gutenberg > Demo.
Verify that Gutenberg demo content is not shown for a new post created via Posts > Add New.
Verify that Gutenberg content is not considered even if manually adding a
&gutenberg-demoquery argument to the URL of any edited post.