WIP: make shift+enter work in lists#13546
Conversation
|
It seems like indent/outdent buttons are not working properly when I have new lines in list items? |
26be204 to
b7eec8d
Compare
|
@youknowriad Hm, seems to work for me. Maybe it's gone after the rebase? If not, could you provide exact steps? |
|
nothing special just use this <!-- wp:list -->
<ul><li>test<br>sdf<br>sdf</li><li>test</li><li>test</li></ul>
<!-- /wp:list -->put the caret in the second list item and click the "indent" button. |
|
Oh sorry! you're right, it's gone after the rebase. |
|
I think, now that we have this PR. We should update the transform from the paragraph to list to avoid creating multiple list items if we have |
|
@youknowriad If I remember correctly that logic was added by intention. I believe someone asked specifically to have it like this, and I kind of agree that it makes sense. Cc @mcsf. |
|
Right now if you select three paragraphs, each one with three lines ( |
|
@youknowriad Yeah that's true. I think we shouldn't convert on line breaks if multiple paragraphs are selected. If only one is selected, we can create list items from every line. How does that sound? |
|
I prefer consistency but it's better yes |
youknowriad
left a comment
There was a problem hiding this comment.
LGTM 👍 Maybe a small e2e test?
|
Yes, just added it :) |
Sounds good to me, @iseulde. |
* WIP: make shift+enter work in lists * Merge similar logic * Add e2e tests
* WIP: make shift+enter work in lists * Merge similar logic * Add e2e tests
Description
Fixes #11215.
How has this been tested?
Screenshots
Types of changes
Checklist: