Merged
Conversation
Member
|
Yes, it should be okey. I hope we find a bit better way to set permissions for all files in the long run. I personally did the same tweak a few weeks back 😅 |
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an error with the
./bin/setup-environment.shcommand by setting thewp-settings.phppermissions to somethingwp-cli core updatewon't complain about.Description
Upon exectuion, I've got the following error:
It looks like the WordPress core update can't proceed due to wp-settings.php permissions.
Test
Executing the command and check that it's able to upgrade to latest WordPress.
I've done this by trying a fresh start (removed docker images and containers, cloned repo, and executed
./bin/setup-environment.shcommand), but if you have a WordPress version < 5.0.3 as the offending line is thecore updatecommand.