Conversation
Adds examples for PHP and JS for using templates. Fixes #8251
gziolo
requested changes
Jan 25, 2019
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
In overall looks good, it needs some consolidation and should be ready to go.
Member
|
@jorgefilipecosta can you double check JS example for |
Update function names to be consistent across example.
gziolo
approved these changes
Jan 25, 2019
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Looks great, thanks for the update. I would appreciate some confirmation from someone familiar with InnerBlocks and templates but this shouldn't be a blocker.
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Expand block template examples Adds examples for PHP and JS for using templates. Fixes #8251 * Consolidate examples and cleanup Update function names to be consistent across example.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Expand block template examples Adds examples for PHP and JS for using templates. Fixes #8251 * Consolidate examples and cleanup Update function names to be consistent across example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds examples for PHP and JS for using templates.
Fixes #8251
How has this been tested?
Implement examples and confirm they work as explained.
See documentation view on branch
Types of changes
Documentation.