Update the gallery block so it limits the columns to the the current number of images#13443
Closed
brentswisher wants to merge 15 commits intoWordPress:masterfrom
Closed
Update the gallery block so it limits the columns to the the current number of images#13443brentswisher wants to merge 15 commits intoWordPress:masterfrom
brentswisher wants to merge 15 commits intoWordPress:masterfrom
Conversation
…removed via the media modal, the columns can't be higher than the new number of images
* Dismissible-notices: fix text overlapping icon (X) * Dismissible-notices: fix text overlapping icon (X) - pt.2.
…#13352) * Organize and reorder Contributors Guide per WordPress#12916 * Remove individual outreach pages, combined into single outreach.md * Principles link, sections heading * Fix link * Fix link, typo * Update docs/contributors/readme.md Co-Authored-By: mkaz <[email protected]> * Remove meetups, there are far too many to list, since most meetups now all cover Gutenberg in some degree or other * Update CONTRIBUTING with links to Documentation section * Update CONTRIBUTING.md Co-Authored-By: mkaz <[email protected]> * Update CONTRIBUTING.md Co-Authored-By: mkaz <[email protected]> * Update CONTRIBUTING.md Co-Authored-By: mkaz <[email protected]> * Update docs/contributors/outreach.md Co-Authored-By: mkaz <[email protected]> * Update docs/contributors/outreach.md Co-Authored-By: mkaz <[email protected]> * Update docs/contributors/document.md Co-Authored-By: mkaz <[email protected]> * Update docs/contributors/document.md Co-Authored-By: mkaz <[email protected]> * Add some newlines, take some away * Paragraph for resources * Update title in generator * Update docs/contributors/develop.md Co-Authored-By: mkaz <[email protected]>
| const { columns } = this.props.attributes; | ||
| this.setAttributes( { | ||
| images: images.map( ( image ) => pickRelevantMediaFiles( image ) ), | ||
| columns: Math.min( images.length, columns ), |
Member
There was a problem hiding this comment.
Maybe we should use columns: columns ? Math.min( images.length, columns ) : columns, here like we do in onRemoveImage. This ensures that we will not set the columns attribute if it was not set before.
Contributor
Author
There was a problem hiding this comment.
Whoa, I updated this to make that change but in trying to rebase my two commits into one I royally messed something up and commits from other people are showing up here. Since it's such a simple code change, Instead of trying to fix this pull request (and likely making it worse), I'm just going to close this and open a different, sorry for the inconvenience @jorgefilipecosta
jorgefilipecosta
added
[Type] Bug
…13439) * add wp-block-categories as prefix * render class names only on the block wrapper * review changes
* Add speak messages to the feature toggle component. * Use plain props.
…s#13483) * Scripts: Add missing root flag to the default Eslint config * scripts: Instruct ESLint to avoid config discovery in defaulting
…removed via the media modal, the columns can't be higher than the new number of images
…isher/gutenberg into update/gallery-max-column-bugfix
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the columns attribute when the
onSelectImagesfunction fires so that if images are removed via the media modal, the columns will be updated. This way columns won't be higher than the new number of images.Previously this worked if removing images via the X in the editor, but not if you removed them via the media modal
Fixes #13423
How has this been tested?
Add a gallery with multiple images, set the columns to be the maximum allowed. Edit the gallery via the media modal and remove images, when you save the media modal, the columns should be adjusted to match the new number of photos.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: