Update and Organize Contributors Guide per #12916#13352
Merged
Conversation
This was referenced Jan 22, 2019
Contributor
|
Hoping to review this today! |
Soean
reviewed
Jan 22, 2019
Soean
reviewed
Jan 22, 2019
mkaz
force-pushed
the
docs/12916/contributors-guide
branch
from
02a3419 to
3a13676
Compare
Co-Authored-By: mkaz <[email protected]>
…w all cover Gutenberg in some degree or other
mkaz
force-pushed
the
docs/12916/contributors-guide
branch
from
d772199 to
9c4d34c
Compare
chrisvanpatten
suggested changes
Jan 23, 2019
Contributor
chrisvanpatten
left a comment
chrisvanpatten
left a comment
There was a problem hiding this comment.
Overall a wonderful improvement; thanks @mkaz 🥇
Just some general notes but on the whole this is a really much-needed streamlining. Thanks for working on this!
Co-Authored-By: mkaz <[email protected]>
Co-Authored-By: mkaz <[email protected]>
Co-Authored-By: mkaz <[email protected]>
Co-Authored-By: mkaz <[email protected]>
Co-Authored-By: mkaz <[email protected]>
Co-Authored-By: mkaz <[email protected]>
Co-Authored-By: mkaz <[email protected]>
mcsf
reviewed
Jan 23, 2019
Co-Authored-By: mkaz <[email protected]>
chrisvanpatten
approved these changes
Jan 23, 2019
Contributor
chrisvanpatten
left a comment
chrisvanpatten
left a comment
There was a problem hiding this comment.
I'm happy with this! I think it's worth landing and iterating further in separate PRs if necessary.
daniloercoli
added a commit
that referenced
this pull request
Jan 24, 2019
…rnmobile/372-add-title-to-gutenberg-mobile * 'master' of https://github.com/WordPress/gutenberg: (56 commits) Save package-lock.json file changes (#13481) Plugin: Deprecate gutenberg_add_responsive_body_class (#13461) Add speak messages to the feature toggle component. (#13385) Plugin: Deprecate gutenberg_kses_allowedtags (#13460) Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472) Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446) Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473) Fix: Categories block: add custom classes only to wrapper (#13439) is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428) Update and Organize Contributors Guide per #12916 (#13352) Dismissible-notices: fix text overlapping icon (X) (#13371) Framework: Remove 5.0-merged REST API integrations (#13408) Plugin: Remove 5.0-merged block registration functions, integrations (#13412) Framework: Bump minimum required WP to 5.x (#13370) [Mobile] Improve keyboard hide button (#13415) Improve castError handling of non strings (#13315) Fix: File block add custom class (#13432) Consider making Fullscreen Mode effects visible only on larger screens (#13425) Update plugin version to 4.9.0 (#13436) DateTimePicker: fix prop warning for (#12933) ...
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Organize and reorder Contributors Guide per #12916 * Remove individual outreach pages, combined into single outreach.md * Principles link, sections heading * Fix link * Fix link, typo * Update docs/contributors/readme.md Co-Authored-By: mkaz <[email protected]> * Remove meetups, there are far too many to list, since most meetups now all cover Gutenberg in some degree or other * Update CONTRIBUTING with links to Documentation section * Update CONTRIBUTING.md Co-Authored-By: mkaz <[email protected]> * Update CONTRIBUTING.md Co-Authored-By: mkaz <[email protected]> * Update CONTRIBUTING.md Co-Authored-By: mkaz <[email protected]> * Update docs/contributors/outreach.md Co-Authored-By: mkaz <[email protected]> * Update docs/contributors/outreach.md Co-Authored-By: mkaz <[email protected]> * Update docs/contributors/document.md Co-Authored-By: mkaz <[email protected]> * Update docs/contributors/document.md Co-Authored-By: mkaz <[email protected]> * Add some newlines, take some away * Paragraph for resources * Update title in generator * Update docs/contributors/develop.md Co-Authored-By: mkaz <[email protected]>
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Organize and reorder Contributors Guide per #12916 * Remove individual outreach pages, combined into single outreach.md * Principles link, sections heading * Fix link * Fix link, typo * Update docs/contributors/readme.md Co-Authored-By: mkaz <[email protected]> * Remove meetups, there are far too many to list, since most meetups now all cover Gutenberg in some degree or other * Update CONTRIBUTING with links to Documentation section * Update CONTRIBUTING.md Co-Authored-By: mkaz <[email protected]> * Update CONTRIBUTING.md Co-Authored-By: mkaz <[email protected]> * Update CONTRIBUTING.md Co-Authored-By: mkaz <[email protected]> * Update docs/contributors/outreach.md Co-Authored-By: mkaz <[email protected]> * Update docs/contributors/outreach.md Co-Authored-By: mkaz <[email protected]> * Update docs/contributors/document.md Co-Authored-By: mkaz <[email protected]> * Update docs/contributors/document.md Co-Authored-By: mkaz <[email protected]> * Add some newlines, take some away * Paragraph for resources * Update title in generator * Update docs/contributors/develop.md Co-Authored-By: mkaz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Organize the Contributors Guide per outline defined in #12916
Fixes #12916
Most of the information is from existing documents and organized in to Design, Develop, and Document sections for Contributors. Each of these sections can probably be refined within the section. However the main goal of this PR is to get the documents into a better organized structure with some updates. The goal is not to update every document within the guide and make sure they are up-to-date.
The biggest change was within the Outreach section which included multiple sections for links to external articles, talks, and discussions about Gutenberg. This was combined into a single page.
How has this been tested?
You can view the docs online here
Types of changes
Documentation, primary reorder and structure.