Merged
Conversation
added 28 commits
October 30, 2018 16:28
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
Thank you for your contribution @timwright12. The label change seems to be working and now we see "URL Slug" as shown in your screen shot. I fear some users may not know what "slug" means but I don't have a better idea.
cc: @jasmussen, @karmatosed as they may be able to provide some ideas.
package-lock.json
Outdated
| "yargs": { | ||
| "version": "11.1.0", | ||
| "resolved": "http://registry.npmjs.org/yargs/-/yargs-11.1.0.tgz", | ||
| "resolved": "https://registry.npmjs.org/yargs/-/yargs-11.1.0.tgz", |
Member
There was a problem hiding this comment.
I think this URL changes may be unintentional? If they are intentional maybe we can do the update to https in a separate PR.
Contributor
Author
There was a problem hiding this comment.
@jorgefilipecosta I think that just happened on the npm install, but I can manually revert it if it's a concern
Contributor
|
I agree "slug" isn't the best word. "Link title (URL slug)" might work better? |
timwright12
requested review from
gziolo,
noisysocks and
youknowriad
as code owners
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* merge from upstream * local save * darked focus state outline for block lists * sasve * updated permalink labelling * reverted package lock * updated label and added helper link * post link text update * Update index.js
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* merge from upstream * local save * darked focus state outline for block lists * sasve * updated permalink labelling * reverted package lock * updated label and added helper link * post link text update * Update index.js
This was referenced Apr 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12033
How has this been tested?
Browser
Local Unit
Local e2e
Screenshots
Types of changes
Bug fix/suggestion to update the permalink label to be more descriptive
Checklist: