You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tests ran: npm run check-licenses and npm run lint-js
Types of changes
New feature: Added (CC-BY-4.0 AND MIT) in the list of GPL 2 compatible licenses
Checklist:
My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.
I've included developer documentation if appropriate.
bfintal
changed the title
Added @fortawesome license in compatible licenses
Added FortAwesome/Font-Awesome license in list of GPL 2 compatible licenses
Dec 16, 2018
bfintal
changed the title
Added FortAwesome/Font-Awesome license in list of GPL 2 compatible licenses
Scripts: Added FortAwesome/Font-Awesome license in list of GPL 2 compatible licenses
Dec 16, 2018
An aside to the specific change, but if there's an established pattern of defining multilicensed projects using (X AND Y), maybe we could automate the parsing to check that each are individually valid licenses. As I write this, I see we do this already for "OR" combinations. Perhaps worth creating as a separate task?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've added the license
(CC-BY-4.0 AND MIT)in the list of GPL 2 compatible licenses, it's the license label used by https://github.com/FortAwesome/Font-Awesome FontAwesome isn't used in Gutenberg, but the addition is for other projects that can usecheck-licensesHow has this been tested?
Tests ran:
npm run check-licensesandnpm run lint-jsTypes of changes
New feature: Added
(CC-BY-4.0 AND MIT)in the list of GPL 2 compatible licensesChecklist: