Try fixing the tab navigation issue#12390
Conversation
|
This will break:
|
|
I'm fine figuring out another way to set the caret at the end. |
youknowriad
added
the
[Type] Bug
|
Thanks a million for getting to this while I stepped away from my Mac for a few hours! 😅 I would certainly like to see this in the WordPress 5.0 release, are others cool with seeing it in? I don't think it's mandatory (I didn't consider it a blocker per se) but it's certainly a low-risk code-wise to me for a significant win. What's the process for patching RC at this point? Is it just to merge it into master like was done and then cut a patch release for 4.6 that Core will use? |
|
I thought anything that gets committed in 4.6 is meant to be merged in WP 5.0? |
|
I think the idea would be something like a 4.5.2, based on that Slack discussion, would have fixes like this cherry-picked if approved by the release lead (@m). I think all commits against 5.0 now need to go through the appropriate release lead (for a11y, me) and @pento or @m: https://wordpress.slack.com/archives/C02RQBWTW/p1542966281138400 I think this would be worth including as the fix is low-risk for high-reward. |
mtias
added
the
[Focus] Accessibility (a11y)
…rnmobile/danilo-try-to-fix-undo-redo * 'master' of https://github.com/WordPress/gutenberg: Avoid changing default wpautop priority (#11722) Try fixing the tab navigation issue (#12390) Polish editor style documentation (#12381)
5 participants
Rerendring RichText components was stealing the focus causing a tab navigation issue.
Fixes #11773.