Only initialise TinyMCE once per instance#12386
Merged
youknowriad merged 1 commit intomasterfrom Nov 30, 2018
Merged
Conversation
ellatrix
added
the
[Feature] Rich Text
youknowriad
reviewed
Nov 28, 2018
| * Initializes TinyMCE. Can only be called once per instance. | ||
| */ | ||
| initialize() { | ||
| if ( this.initialize.called ) { |
Contributor
There was a problem hiding this comment.
Why not just this.initialized 🤷♂️
I find it a bit weird to attach a property to the method while we have access to the object but it's minor.
Member
Author
There was a problem hiding this comment.
It's local state. But I don't mind either way.
Member
Author
|
@mtias Removing the "[External Package] TinyMCE" as that's only for issue in TinyMCE. |
daniloercoli
added a commit
that referenced
this pull request
Nov 30, 2018
…rnmobile/danilo-try-to-fix-undo-redo * 'master' of https://github.com/WordPress/gutenberg: Autocompleters: Consider block category (#12287) Only init TinyMCE once per instance (#12386) RichText: convert HTML formatting whitespace to spaces (#12166) Notices: Remove "files" block in package.json (#12438) Edit Post: Avoid rendering AdminNotices compatibility component (#12444) Correct the docs manifest (#12411)
daniloercoli
added a commit
that referenced
this pull request
Nov 30, 2018
…HEAD * 'master' of https://github.com/WordPress/gutenberg: [RNmobile] Fix problems with undo/redo on Android (#12417) Add registry param to withDispatch component (#11851) Autocompleters: Consider block category (#12287) Only init TinyMCE once per instance (#12386) RichText: convert HTML formatting whitespace to spaces (#12166) Notices: Remove "files" block in package.json (#12438) Edit Post: Avoid rendering AdminNotices compatibility component (#12444) Correct the docs manifest (#12411)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently we're trying to initialise TinyMCE every time the content editable element receives focus.
How has this been tested?
Screenshots
Types of changes
Checklist: