Refactor onChangeEditableValue handling (version1)#12099
Closed
Refactor onChangeEditableValue handling (version1)#12099
Conversation
9d2e44a to
5739ab9
Compare
4 tasks
Move it to the `rich-text` package.
5739ab9 to
16b4bd6
Compare
Member
Member
|
Yeah, I need to look into it when I find some time... |
5 tasks
Member
|
Fixed in #14284. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #11861, @iseulde pointed out that ideally
RichTextshould not 'know' anything about custom formats. So the handling ofonChangeEditableValueshould move to therich-textpackage. Specifically thecreatefunction.This is an attempt to execute this refactor. It works functionally, but the implementation has a ton of duplication. The problem I was trying to solve was that
toFormatstrips the relevant information we need when building the list of formats for the value. So to circumvent this, I build another array withshadowFormatsthat contains all formats that are actually in the DOM.This
shadowFormatsarray is then send toonChangeEditableValue.Note: The actual
onChangeEditableValueinRichTextneeds to move too, but I wanted to have these versions out asap to address the complexity and moving that function itself over is trivial so can be done after choosing how to refactor.How has this been tested?
The e2e tests still pass, I have tested that annotations still work.
Screenshots
Types of changes
Checklist: