render_block_core_latest_posts() use get_posts() instead of wp_get_recen…#11984
render_block_core_latest_posts() use get_posts() instead of wp_get_recen…#11984gziolo merged 4 commits intoWordPress:masterfrom
Conversation
ghost
force-pushed
the
core_latest_posts
branch
from
8ae5857 to
b252b4c
Compare
|
@swissspidy Hello! Can you please check if it looks like what you suggested? |
ghost
force-pushed
the
core_latest_posts
branch
from
23ec043 to
2bbbecd
Compare
|
@swissspidy is there a chance to include this change to WP 5.0? |
ghost
force-pushed
the
core_latest_posts
branch
from
7a85740 to
74863ce
Compare
|
@grey-rsi Would you mind rebasing or merging the master branch into yours to fix the conflict? Thanks! After that I think this is good to go. |
|
@swissspidy sorry for delay, missed your comment. I have merged my changes so it should be fine now |
ghost
force-pushed
the
core_latest_posts
branch
2 times, most recently
from
967e9ea to
3521d2e
Compare
|
@swissspidy can you please update if you're going to include this to WP 5.0 or 5.0.1? We will be very appreciate if you can include it. Thanks! |
|
@grey-rsi Thanks for the ping. This is not really my call to make, but I think it's ready for inclusion in 5.0.1. I updated the milestone accordingly. |
|
@swissspidy Thanks a lot for the reply! |
|
@grey-rsi Would you mind making a patch for this change against the WordPress 5.0 branch and upload it to https://core.trac.wordpress.org/ticket/45349? Thanks! |
|
@swissspidy added a patch file, Thanks for update! |
mcsf
left a comment
mcsf
left a comment
There was a problem hiding this comment.
This needs more testing before we can merge confidently. Punting to the next release.
|
@grey-rsi - it looks like there are some e2e test failures which might be caused by some changes introduced in this PR. It would be surprising, but I would recommend bringing this branch up to date with the latest changes applied to |
|
@grey-rsi congratulation on your first code contribution to Gutenberg 🎉 |
|
@mcsf @gziolo @swissspidy I really appreciate your help, Thanks a lot guys! |
…cen… (#11984) * render_block_core_latest_posts() use get_posts() instead of wp_get_recent_posts() * small fix * small fix
…cen… (#11984) * render_block_core_latest_posts() use get_posts() instead of wp_get_recent_posts() * small fix * small fix
6 participants
…t_posts()
Description
Use get_posts() instead of wp_get_recent_posts(). In this way, thirty-party plugins don't have a limitation in filtering query results
it was proposed here #11195 (comment)
Checklist: