Support passing a context variable to the custom format prepareEditTreeValue#11630
Merged
youknowriad merged 1 commit intotry/prepare-editablefrom Nov 9, 2018
Merged
Support passing a context variable to the custom format prepareEditTreeValue#11630youknowriad merged 1 commit intotry/prepare-editablefrom
youknowriad merged 1 commit intotry/prepare-editablefrom
Conversation
youknowriad
added
the
[Feature] Rich Text
tofumatt
approved these changes
Nov 8, 2018
Member
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
Makes sense to me; seems like it'd be a good fit for some unit tests, but I know timelines are tight and it's experimental 🤷♂️
Member
|
Any plans to add |
Contributor
Author
|
@gziolo Could be done as needed. This is just a first iteration to implement the concept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an identifier prop to the RichText component.
It also passes the "clientId" and "richTextIdentifier" as "context" to the format API.