Add "img" as a keyword for the image block#10955
Merged
chrisvanpatten merged 2 commits intoOct 23, 2018
Merged
Conversation
aduth
approved these changes
Oct 23, 2018
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Because this is intended to mirror the HTML tag, I did not wrap this string in a translation method as HTML doesn't translate.
If it's potentially confusing for a future maintainer, could be good to note via an inline comment.
antpb
pushed a commit
to antpb/gutenberg
that referenced
this pull request
Oct 26, 2018
* Add "img" as a keyword for the image block * Add comment for future maintainers on why we don't translate "img"
Member
|
Thanks for this change, it's a nice little experience improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds "img" as a keyword for the image block, mirroring the HTML
<img>tag.Because this is intended to mirror the HTML tag, I did not wrap this string in a translation method as HTML doesn't translate.
This is in response to Jeff Chandler's [feedback on Twitter](https://twitter.com/jeffr0/status/1054550924541210625_:
We already support
h*keywords for the Heading block and theblockquotekeyword for the Quote block; this is a natural extension of that behavior.