-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Closed
Labels
Backwards CompatibilityIssues or PRs that impact backwards compatabilityIssues or PRs that impact backwards compatabilityGutenberg PluginIssues or PRs related to Gutenberg Plugin management related effortsIssues or PRs related to Gutenberg Plugin management related efforts[Feature] NotesPhase 3 of the Gutenberg roadmap around block commentingPhase 3 of the Gutenberg roadmap around block commenting[Type] TaskIssues or PRs that have been broken down into an individual action to takeIssues or PRs that have been broken down into an individual action to take
Description
What problem does this address?
We have directly implemented several bug fixes and feature enhancements for the Notes feature within the core.
These changes should be backported from the core for environments where the latest Gutenberg plugin is enabled in WordPress 6.8.
This work is not related to the 6.9 release, but it would be best to complete it as soon as possible.
What is your proposed solution?
In my investigation, the following three changesets need to be backported. There might be others as well. I have also included testing procedures for each issue.
Note: The following issues have been resolved in the latest WordPress core, so don't forget to downgrade the WordPress version to 6.8 and test it.
✅ 1. Flood comments should be ignored
Completed: #73232
- Log in as a contributor user.
- Quickly add multiple notes.
- The message
You are posting comments too quickly. Slow down.is displayed, but this should not be displayed.
✅ 2. Email notification
Completed: #73645
- Set up the WP Mail SMTP plugin or similar tools to enable email sending detection in your local environment.
Create a post. - Log in with a different user account and add a note to that post.
- An email should be sent.
✅ 3. Ensure notes never show on the comments page.
Completed: #73640
- Add a note.
- Access: http://localhost:8888/wp-admin/edit-comments.php?comment_type=note.
- Notes are displayed, but that shouldn't be the case.
✅ 4. Avoid incrementing comment_count when notes are resolved or reopened
Completed: #73689
- Create and publish a new post.
- Open the post on the front-end and add a normal comment to the post.
- The comment section says
One response to “{post_title}”, which is correct. - Add a block, add a note to it, resolve the note, and save the post.
- Open the post on the front-end.
- The comment section says
3 responses to “Test”, which is incorrect. - Access http://localhost:8888/wp-admin/edit-comments.php
- The "In response to" column shows the number of comments as 3, which is incorrect.
adamsilverstein, Mamaduka and jeffpaul
Metadata
Metadata
Assignees
Labels
Backwards CompatibilityIssues or PRs that impact backwards compatabilityIssues or PRs that impact backwards compatabilityGutenberg PluginIssues or PRs related to Gutenberg Plugin management related effortsIssues or PRs related to Gutenberg Plugin management related efforts[Feature] NotesPhase 3 of the Gutenberg roadmap around block commentingPhase 3 of the Gutenberg roadmap around block commenting[Type] TaskIssues or PRs that have been broken down into an individual action to takeIssues or PRs that have been broken down into an individual action to take