Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select box display does not update when font size is reset #67721

Closed
3 of 6 tasks
inc2734 opened this issue Dec 9, 2024 · 2 comments · Fixed by #67733
Closed
3 of 6 tasks

Select box display does not update when font size is reset #67721

inc2734 opened this issue Dec 9, 2024 · 2 comments · Fixed by #67733
Assignees
@subodhr258
Labels
[Feature] Typography Font and typography-related issues and PRs [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@inc2734
Copy link
Contributor

inc2734 commented Dec 9, 2024

Description

If the font size is reset while the font size choice is in the select box, the value is reset, but the select box display is not updated.

Step-by-step reproduction instructions

  1. Add font size presets.
  2. Go to block editor.
  3. Add a paragraph to the document.
  4. Open the Typography panel.
  5. Change the font size.
  6. Click “reset” to clear the font size.

Screenshots, screen recording, code snippet

Kapture.2024-12-09.at.14.51.38.mp4

Environment info

  • WordPress 6.7.1

and

  • WordPress 6.7.1
  • Gutenberg 19.8.0

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@inc2734 inc2734 added the [Type] Bug An existing feature does not function as intended label Dec 9, 2024
@Mamaduka Mamaduka added the [Feature] Typography Font and typography-related issues and PRs label Dec 9, 2024
@subodhr258
Copy link
Contributor

subodhr258 commented Dec 9, 2024 •
edited
Loading

I was able to reproduce this bug. When the dropdown is being used, there is no immediate change reflected in the dropdown when we click on the RESET button.
It is only reflected when we click anywhere outside the box. Working on fixing this.

Recording in local:
https://github.com/user-attachments/assets/4ee3477c-681f-4196-8b57-7f3b51f96d6a

@Rishit30G
Copy link
Contributor

Rishit30G commented Dec 9, 2024 •
edited
Loading

To add more to the solution of this issue, as per my findings I could see that when the RESET button is clicked the value in the dropdown still remains the same even though the UI changes are taking place

Files that can potentially be debugged:
packages/components/src/custom-select-control/index.tsx
packages/components/src/tools-panel/tools-panel-header/component.tsx

Sharing a screencast:
https://github.com/user-attachments/assets/adb89b29-98fc-4a8a-b366-91645e78dbe8

@subodhr258 subodhr258 mentioned this issue Dec 9, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 9, 2024
@yogeshbhutkar yogeshbhutkar mentioned this issue Dec 11, 2024
Merged
@Mamaduka Mamaduka mentioned this issue Jan 13, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@subodhr258 subodhr258

Labels
[Feature] Typography Font and typography-related issues and PRs [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CustomSelectControl: Update Value from Fresh State subodhr258/gutenberg
4 participants
@Mamaduka @inc2734 @subodhr258 @Rishit30G