-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Block API: Change block mutation functions from undefined to noop in locked template #6587
Copy link
Copy link
Closed as not planned
Closed as not planned
Copy link
Labels
Developer ExperienceIdeas about improving block and theme developer experienceIdeas about improving block and theme developer experience[Feature] Block APIAPI that allows to express the block paradigm.API that allows to express the block paradigm.[Priority] LowUsed to indicate that the issue at hand isn't a top priority to address and can be handled laterUsed to indicate that the issue at hand isn't a top priority to address and can be handled later[Type] TaskIssues or PRs that have been broken down into an individual action to takeIssues or PRs that have been broken down into an individual action to take
Metadata
Metadata
Assignees
Labels
Developer ExperienceIdeas about improving block and theme developer experienceIdeas about improving block and theme developer experience[Feature] Block APIAPI that allows to express the block paradigm.API that allows to express the block paradigm.[Priority] LowUsed to indicate that the issue at hand isn't a top priority to address and can be handled laterUsed to indicate that the issue at hand isn't a top priority to address and can be handled later[Type] TaskIssues or PRs that have been broken down into an individual action to takeIssues or PRs that have been broken down into an individual action to take
Type
Fields
Give feedbackNo fields configured for issues without a type.
Previously: https://github.com/WordPress/gutenberg/pull/3686/files#r185262287
Currently, a block implementer may need to anticipate that any of the following functions may be
undefinedif the post template is locked for editing:insertBlocksAfteronReplacemergeBlocksInstead of placing the burden on the developer to differentiate between the type, we should simply pass it as a function regardless of whether the template is locked. If it is a locked template, the function should effectively be a noop.
Open questions:
withSelect, and could additionally be passed as a prop to the block'seditcomponent.