-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Framework: Extract notices state from editor module #6388
Copy link
Copy link
Closed
Labels
Backwards CompatibilityIssues or PRs that impact backwards compatabilityIssues or PRs that impact backwards compatability[Type] EnhancementA suggestion for improvement.A suggestion for improvement.[Type] Plugin InteroperabilityIncompatibilities between a specific plugin and the block editor. Close with workaround notes.Incompatibilities between a specific plugin and the block editor. Close with workaround notes.[Type] TaskIssues or PRs that have been broken down into an individual action to takeIssues or PRs that have been broken down into an individual action to take
Milestone
Metadata
Metadata
Assignees
Labels
Backwards CompatibilityIssues or PRs that impact backwards compatabilityIssues or PRs that impact backwards compatability[Type] EnhancementA suggestion for improvement.A suggestion for improvement.[Type] Plugin InteroperabilityIncompatibilities between a specific plugin and the block editor. Close with workaround notes.Incompatibilities between a specific plugin and the block editor. Close with workaround notes.[Type] TaskIssues or PRs that have been broken down into an individual action to takeIssues or PRs that have been broken down into an individual action to take
Type
Fields
Give feedbackNo fields configured for issues without a type.
Notices are not an editor-specific feature, yet the current notices state lives within
editor. Before plugins start integrating more with this functionality, we should consider whether to extract it, either to its own module (like viewport), or tocomponents, or perhaps even to a new concept of "data-bound components".See also #5316 which highlights some issues with the viewport approach of independent data modules exporting their own components, as it can result in circular dependencies between components and the individual module.
Proposal options:
noticesfolder, which creates its owndatastatenoticescomponent tocomponentsdirectory, which bundles its owndatastateOpen questions:
Do we need concepts of scoped notices? If a plugin adds a notice and intends for it to be shown in the editor, how does this scale out to a more general solution? Is this something we need to address now?