@wordpress/primitives is missing a dependency on react #62250
Description
@wordpress/primitives is lacking a dependency or peer dependency on react.
This happens to work with npm's hoisting due to other dependencies pulling that package in, but will fail with yarn's p'n'p or pnpm with hoisting disabled.
This seems to have begun with #61692.
Reproduction
With yarn:
- Create a temporary directory, and cd into it.
echo '{}' > package.jsonyarn set version stableyarn add @wordpress/primitives- Run
yarn node -e 'const x = require( "@wordpress/primitives" );'
With pnpm:
- Create a temporary directory, and cd into it.
echo 'hoist-pattern=[]' > .npmrcpnpm add @wordpress/primitives(note pnpm 8 defaults to installing peer deps)- Run
node -e 'const x = require( "@wordpress/primitives" );'
Expected behavior
Command runs.
Actual behavior
With yarn:
Error: @wordpress/primitives tried to access react, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.
Required package: react (via "react/jsx-runtime")
Required by: @wordpress/primitives@npm:4.0.0 (via /home/user/.yarn/berry/cache/@wordpress-primitives-npm-4.0.0-bfa939d68d-10c0.zip/node_modules/@wordpress/primitives/build/svg/)
Require stack:
- /home/user/.yarn/berry/cache/@wordpress-primitives-npm-4.0.0-bfa939d68d-10c0.zip/node_modules/@wordpress/primitives/build/svg/index.js
- /home/user/.yarn/berry/cache/@wordpress-primitives-npm-4.0.0-bfa939d68d-10c0.zip/node_modules/@wordpress/primitives/build/index.js
- /tmp/test/[eval]
at require$$0.Module._resolveFilename (/tmp/test/.pnp.cjs:5959:13)
at Module._load (node:internal/modules/cjs/loader:986:27)
at require$$0.Module._load (/tmp/test/.pnp.cjs:5850:31)
at Module.require (node:internal/modules/cjs/loader:1233:19)
at require (node:internal/modules/helpers:179:18)
at Object.<anonymous> (/home/user/.yarn/berry/cache/@wordpress-primitives-npm-4.0.0-bfa939d68d-10c0.zip/node_modules/@wordpress/primitives/build/svg/index.js:10:19)
at Module._compile (node:internal/modules/cjs/loader:1358:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
at require$$0.Module._extensions..js (/tmp/test/.pnp.cjs:6002:33)
at Module.load (node:internal/modules/cjs/loader:1208:32)
With pnpm:
Error: Cannot find module 'react/jsx-runtime'
Require stack:
- /tmp/test/node_modules/.pnpm/@[email protected]/node_modules/@wordpress/primitives/build/svg/index.js
- /tmp/test/node_modules/.pnpm/@[email protected]/node_modules/@wordpress/primitives/build/index.js
- /tmp/test/[eval]
at Module._resolveFilename (node:internal/modules/cjs/loader:1145:15)
at Module._load (node:internal/modules/cjs/loader:986:27)
at Module.require (node:internal/modules/cjs/loader:1233:19)
at require (node:internal/modules/helpers:179:18)
at Object.<anonymous> (/tmp/test/node_modules/.pnpm/@[email protected]/node_modules/@wordpress/primitives/build/svg/index.js:10:19)
at Module._compile (node:internal/modules/cjs/loader:1358:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
at Module.load (node:internal/modules/cjs/loader:1208:32)
at Module._load (node:internal/modules/cjs/loader:1024:12)
at Module.require (node:internal/modules/cjs/loader:1233:19) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/tmp/test/node_modules/.pnpm/@[email protected]/node_modules/@wordpress/primitives/build/svg/index.js',
'/tmp/test/node_modules/.pnpm/@[email protected]/node_modules/@wordpress/primitives/build/index.js',
'/tmp/test/[eval]'
]
}