-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Closed
Labels
[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Changes that impact accessibility and need corresponding review (e.g. markup changes).[Package] Edit Site/packages/edit-site/packages/edit-site[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Description
Description
In the Site Editor, there are two links to go back to the Dashboard. They're visually presented as 'icon buttons'.
The first one is the WP / site logo. It's labelled aria-label="Go back to the dashboard".
The second one is the 'back' icon button. It's labelled aria-label="Navigate to the Dashboard".
Also:
- The WP / sito logo doesn't have a tooltip. Icon buttons must visually expose their accessible name in some way. At the vry least, with a tooltip.
- The back icon button tooltip text is just
Dashboard, which mismatches the actual accessible name.
This is less than ideal from an accessibility perspective.
- Controls that do the same thing should be labelled consistently.
- A control's tooltip is meant to visually expose its accessible name. Tooltip text and aria-label must match.
Also, ideally the visuals of an icon button should clearly suggest its actual accessible name. Users should be able to guess the actual accessible name by the icon. This is particularly important for speech recognition software users. As a user:
- I do see an icon that looks like a left arrow. That mimis the well-known convention of the browsers back button. It suggest me the idea of 'back', 'go back;.
- Based on that, I'd try a voice command like
Click 'back'. - That voice command would fail because the actual accessible name is
Navigate to the Dashboard.
Step-by-step reproduction instructions
- Go to the Site editor in 'browse mode'.
- Inspect the source of the WP / site logo at the top left.
- Observe the lionk aria-label is
Go back to the dashboard. - Observe the link doesn't show a tooltip on hover or focus.
- Inspect the source of the back icon button.
- Observe the link aria-label is
Navigate to the Dashboard. - Observe the link tooltip is
Dashboard.
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Changes that impact accessibility and need corresponding review (e.g. markup changes).[Package] Edit Site/packages/edit-site/packages/edit-site[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended

