-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Make always-visible block icon accessible and usable #11669
Copy link
Copy link
Closed
Labels
General InterfaceParts of the UI which don't fall neatly under other labels.Parts of the UI which don't fall neatly under other labels.Needs Design FeedbackNeeds general design feedback.Needs general design feedback.[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Changes that impact accessibility and need corresponding review (e.g. markup changes).
Milestone
Metadata
Metadata
Assignees
Labels
General InterfaceParts of the UI which don't fall neatly under other labels.Parts of the UI which don't fall neatly under other labels.Needs Design FeedbackNeeds general design feedback.Needs general design feedback.[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Changes that impact accessibility and need corresponding review (e.g. markup changes).
Type
Fields
Give feedbackNo fields configured for issues without a type.
In #11600, we made the UI always show the block icon.
However it's being displayed in a low opacity state, with the idea being that it's not an active button like the block type switcher.
However, I would argue that in this case, the icon is serving an entirely different purpose than the block switcher button: it's a visual label, which helps indicate/reinforce the current block.
Removing the dropdown arrow changes the context of the icon entirely. Lowering the opacity, as a way of further reinforcing a disabled state, makes the icon inaccessible as a visual aid for indicating the current block.
Further, I would argue that it sends a confusing message. The dimmed block icon can be easily interpreted as a reflection of the block's own state, suggesting the block itself is disabled.
I have a few potential ideas:
Fundamentally, what's the point of always showing the icon if a certain subset of users can't see it?