Remove image source with local file path

ellatrix · ellatrix · commit c9e6e6200631 · 2017-08-24T13:53:14.000+02:00
diff --git a/blocks/api/paste/image-corrector.js b/blocks/api/paste/image-corrector.js
@@ -0,0 +1,20 @@
+/**
+ * Browser dependencies
+ */
+const { ELEMENT_NODE } = window.Node;
+
+export default function( node ) {
+	if ( node.nodeType !== ELEMENT_NODE ) {
+		return;
+	}
+
+	if ( node.nodeName !== 'IMG' ) {
+		return;
+	}
+
+	if ( node.src.indexOf( 'file:' ) !== 0 ) {
+		return;
+	}
+
+	node.src = '';
+}
diff --git a/blocks/api/paste/index.js b/blocks/api/paste/index.js
@@ -16,6 +16,7 @@ import createUnwrapper from './create-unwrapper';
 import isInlineContent from './is-inline-content';
 import formattingTransformer from './formatting-transformer';
 import msListConverter from './ms-list-converter';
+import imageCorrector from './image-corrector';
 import { deepFilter, isInline, isSpan, isWrapper, isInvalidInline } from './utils';
 
 export default function( { content: HTML, inline } ) {
@@ -47,6 +48,7 @@ export default function( { content: HTML, inline } ) {
 		return HTML;
 	}
 
+	// Context dependent filters. Needs to run before we remove tags.
 	HTML = deepFilter( HTML, [
 		msListConverter,
 	] );
@@ -55,6 +57,7 @@ export default function( { content: HTML, inline } ) {
 		formattingTransformer,
 		stripAttributes,
 		commentRemover,
+		imageCorrector,
 		createUnwrapper( ( node ) => isWrapper( node ) ),
 		createUnwrapper( ( node ) => isSpan( node ) ),
 		createUnwrapper( ( node ) => node.nodeName === 'O:P' ),
diff --git a/blocks/api/paste/test/image-corrector.js b/blocks/api/paste/test/image-corrector.js
@@ -0,0 +1,18 @@
+/**
+ * External dependencies
+ */
+import { equal } from 'assert';
+
+/**
+ * Internal dependencies
+ */
+import imageCorrector from '../image-corrector';
+import { deepFilter } from '../utils';
+
+describe( 'imageCorrector', () => {
+	it( 'should correct image source', () => {
+		const input = '<img src="file:LOW-RES.png">';
+		const output = '<img src="">';
+		equal( deepFilter( input, [ imageCorrector ] ), output );
+	} );
+} );
diff --git a/blocks/api/paste/test/integration/ms-word-in.html b/blocks/api/paste/test/integration/ms-word-in.html
@@ -101,9 +101,9 @@ <h2><span lang=EN-US style='mso-ansi-language:EN-US'>This is a heading level 2<o
  <o:lock v:ext="edit" aspectratio="t"/>
 </v:shapetype><v:shape id="Picture_x0020_1" o:spid="_x0000_i1025" type="#_x0000_t75"
  style='width:451pt;height:338pt;visibility:visible;mso-wrap-style:square'>
- <v:imagedata src="file:////Users/iseulde/Library/Group%20Containers/UBF8T346G9.Office/msoclip1/01/clip_image001.jpg"
+ <v:imagedata src="file:ORIGINAL.jpg"
 	o:title=""/>
 </v:shape><![endif]--><![if !vml]><img border=0 width=451 height=338
-src="file:////Users/iseulde/Library/Group%20Containers/UBF8T346G9.Office/msoclip1/01/clip_image002.png"
+src="file:LOW-RES.png"
 v:shapes="Picture_x0020_1"><![endif]></span><span lang=EN-US style='mso-ansi-language:
 EN-US'><o:p></o:p></span></p>
diff --git a/blocks/api/paste/test/integration/ms-word-out.html b/blocks/api/paste/test/integration/ms-word-out.html
@@ -45,5 +45,5 @@ <h2>This is a heading level 2</h2>
 <!-- /wp:core/paragraph -->
 
 <!-- wp:core/image -->
-<figure class="wp-block-image"><img src="file:////Users/iseulde/Library/Group%20Containers/UBF8T346G9.Office/msoclip1/01/clip_image002.png" /></figure>
+<figure class="wp-block-image"><img src="" /></figure>
 <!-- /wp:core/image -->
