Refactor PatternConvertButton to ensure closeBlockSettingsMenu is called consistently on modal close and block conversion actions.

ramonjd · ramonjd · commit c62af53c396e · 2026-02-17T18:18:59.000+11:00
diff --git a/packages/patterns/src/components/pattern-convert-button.js b/packages/patterns/src/components/pattern-convert-button.js
@@ -143,7 +143,6 @@ export default function PatternConvertButton( {
 
 			replaceBlocks( clientIds, newBlock );
 			setEditingPattern( newBlock.clientId, true );
-			closeBlockSettingsMenu();
 		}
 
 		createSuccessNotice(
@@ -164,6 +163,7 @@ export default function PatternConvertButton( {
 			}
 		);
 		setIsModalOpen( false );
+		closeBlockSettingsMenu();
 	};
 	return (
 		<>
@@ -186,6 +186,7 @@ export default function PatternConvertButton( {
 					} }
 					onClose={ () => {
 						setIsModalOpen( false );
+						closeBlockSettingsMenu();
 					} }
 				/>
 			) }
