Sync all meta by default

chriszarate · chriszarate · commit 6814b700de10 · 2025-10-24T14:14:48.000-06:00
diff --git a/packages/core-data/src/utils/crdt-meta.ts b/packages/core-data/src/utils/crdt-meta.ts
diff --git a/packages/core-data/src/utils/crdt.ts b/packages/core-data/src/utils/crdt.ts
@@ -21,7 +21,6 @@ import { type Post } from '../entity-types/post';
 import { type Type } from '../entity-types';
 import { CRDT_RECORD_MAP_KEY } from '../sync';
 import type { WPBlockSelection, WPSelection } from '../types';
-import { shouldSyncMetaForPostType } from './crdt-meta';
 
 export type PostChanges = Partial< Post > & {
 	blocks?: Block[];
@@ -52,6 +51,9 @@ const allowedPostProperties = new Set< string >( [
 	'title',
 ] );
 
+// Post meta keys that should *not* be synced.
+const disallowedPostMetaKeys = new Set< string >( [] );
+
 /**
  * Given a set of local changes to a generic entity record, apply those changes
  * to the local Y.Doc.
@@ -94,13 +96,13 @@ export function defaultApplyChangesToCRDTDoc(
  *
  * @param {CRDTDoc}     ydoc
  * @param {PostChanges} changes
- * @param {Type}        postType
+ * @param {Type}        _postType
  * @return {void}
  */
 export function applyPostChangesToCRDTDoc(
 	ydoc: CRDTDoc,
 	changes: PostChanges,
-	postType: Type
+	_postType: Type // eslint-disable-line @typescript-eslint/no-unused-vars
 ): void {
 	const ymap = ydoc.getMap( CRDT_RECORD_MAP_KEY );
 
@@ -162,9 +164,7 @@ export function applyPostChangesToCRDTDoc(
 				// should be synced.
 				Object.entries( newValue ?? {} ).forEach(
 					( [ metaKey, metaValue ] ) => {
-						if (
-							! shouldSyncMetaForPostType( metaKey, postType )
-						) {
+						if ( disallowedPostMetaKeys.has( metaKey ) ) {
 							return;
 						}
 
@@ -232,13 +232,13 @@ export function defaultGetChangesFromCRDTDoc( crdtDoc: CRDTDoc ): ObjectData {
  *
  * @param {CRDTDoc} ydoc
  * @param {Post}    editedRecord
- * @param {Type}    postType
+ * @param {Type}    _postType
  * @return {Partial<PostChanges>} The changes that should be applied to the local record.
  */
 export function getPostChangesFromCRDTDoc(
 	ydoc: CRDTDoc,
 	editedRecord: Post,
-	postType: Type
+	_postType: Type // eslint-disable-line @typescript-eslint/no-unused-vars
 ): PostChanges {
 	const ymap = ydoc.getMap( CRDT_RECORD_MAP_KEY );
 
@@ -280,7 +280,7 @@ export function getPostChangesFromCRDTDoc(
 					allowedMetaChanges = Object.fromEntries(
 						Object.entries( newValue ?? {} ).filter(
 							( [ metaKey ] ) =>
-								shouldSyncMetaForPostType( metaKey, postType )
+								! disallowedPostMetaKeys.has( metaKey )
 						)
 					);
 
diff --git a/packages/core-data/src/utils/test/crdt.ts b/packages/core-data/src/utils/test/crdt.ts
@@ -153,7 +153,7 @@ describe( 'crdt', () => {
 			expect( blocks ).toBeInstanceOf( Y.Array );
 		} );
 
-		it( 'syncs non-hidden meta fields', () => {
+		it( 'syncs meta fields', () => {
 			const changes = {
 				meta: {
 					some_meta: 'new value',
@@ -169,24 +169,6 @@ describe( 'crdt', () => {
 			expect( metaMap.get( 'some_meta' ) ).toBe( 'new value' );
 		} );
 
-		it( 'does not sync hidden meta fields', () => {
-			const changes = {
-				meta: {
-					_private_meta: 'unsynced value',
-					some_meta: 'new value',
-				},
-			};
-
-			const metaMap = new Y.Map< unknown >();
-			metaMap.set( 'some_meta', 'old value' );
-			map.set( 'meta', metaMap );
-
-			applyPostChangesToCRDTDoc( doc, changes, mockPostType );
-
-			expect( metaMap.has( '_private_meta' ) ).toBe( false );
-			expect( metaMap.get( 'some_meta' ) ).toBe( 'new value' );
-		} );
-
 		it( 'initializes meta as Y.Map when not present', () => {
 			const changes = {
 				meta: {
@@ -299,15 +281,13 @@ describe( 'crdt', () => {
 			expect( changes ).toHaveProperty( 'blocks' );
 		} );
 
-		it( 'includes meta in changes, preserving any unsynced fields', () => {
+		it( 'includes meta in changes', () => {
 			map.set( 'meta', {
-				_private_meta: 'ignored value',
 				public_meta: 'new value',
 			} );
 
 			const editedRecord = {
 				meta: {
-					_private_meta: 'preserved value',
 					public_meta: 'old value',
 				},
 			} as unknown as Post;
@@ -319,7 +299,6 @@ describe( 'crdt', () => {
 			);
 
 			expect( changes.meta ).toEqual( {
-				_private_meta: 'preserved value', // preserved from edited record
 				public_meta: 'new value', // from CRDT
 			} );
 		} );
