Enhance image flipping functionality in Gutenberg REST Attachments Controller

ramonjd · ramonjd · commit 2904c808f2e8 · 2025-09-24T15:39:25.000+10:00
- Updated the `Gutenberg_REST_Attachments_Controller` to handle both vertical and horizontal flipping of images by modifying the request structure.
- Refactored the test case to reflect the new functionality, adding a separate test for vertical flipping.
diff --git a/lib/compat/wordpress-6.9/class-gutenberg-rest-attachments-controller.php b/lib/compat/wordpress-6.9/class-gutenberg-rest-attachments-controller.php
@@ -62,11 +62,16 @@ public function edit_media_item( $request ) {
 		} else {
 			$modifiers = array();
 
-			if ( ! empty( $request['flip'] ) ) {
+			if ( isset( $request['flip']['horizontal'] ) || isset( $request['flip']['vertical'] ) ) {
+				$flip_args = array(
+					'vertical'   => $request['flip']['vertical'] ?? 0,
+					'horizontal' => $request['flip']['horizontal'] ?? 0,
+				);
+
 				$modifiers[] = array(
 					'type' => 'flip',
 					'args' => array(
-						'flip' => $request['flip'],
+						'flip' => $flip_args,
 					),
 				);
 			}
diff --git a/phpunit/class-gutenberg-rest-attachments-controller-test.php b/phpunit/class-gutenberg-rest-attachments-controller-test.php
@@ -131,12 +131,12 @@ public function test_edit_image_updates_attachment_fields() {
 	}
 
 	/**
-	 * Tests that the image is flipped correctly.
+	 * Tests that the image is flipped correctly vertically and horizontally.
 	 *
 	 * @ticket ???
 	 * @requires function imagejpeg
 	 */
-	public function test_edit_image_flip() {
+	public function test_edit_image_vertical_and_horizontal_flip() {
 		wp_set_current_user( self::$admin_id );
 		$attachment = self::factory()->attachment->create_upload_object( self::$test_file );
 
@@ -161,6 +161,36 @@ public function test_edit_image_flip() {
 		$this->assertSame( array( true, true ), WP_Image_Editor_Mock::$spy['flip'][0] );
 	}
 
+	/**
+	 * Tests that the image is flipped correctly vertically.
+	 *
+	 * @ticket ???
+	 * @requires function imagejpeg
+	 */
+	public function test_edit_image_vertical_flip() {
+		wp_set_current_user( self::$admin_id );
+		$attachment = self::factory()->attachment->create_upload_object( self::$test_file );
+
+		$this->setup_mock_editor();
+		WP_Image_Editor_Mock::$edit_return['flip'] = new WP_Error();
+
+		$params = array(
+			'flip' => array(
+				'vertical' => 1,
+			),
+			'src'  => wp_get_attachment_image_url( $attachment, 'full' ),
+		);
+
+		$request = new WP_REST_Request( 'POST', "/wp/v2/media/{$attachment}/edit" );
+		$request->set_body_params( $params );
+		$response = rest_do_request( $request );
+		$this->assertErrorResponse( 'rest_image_flip_failed', $response, 500 );
+
+		$this->assertCount( 1, WP_Image_Editor_Mock::$spy['flip'] );
+		// The controller converts the integer values to booleans: 0 !== (int) 1 = true
+		$this->assertSame( array( true, false ), WP_Image_Editor_Mock::$spy['flip'][0] );
+	}
+
 	public function test_register_routes() {
 		$this->markTestSkipped( 'No need to implement' );
 	}
