feedback

ntsekouras · ntsekouras · commit 006954dc805f · 2025-11-14T14:13:57.000+02:00
diff --git a/packages/block-library/src/breadcrumbs/edit.js b/packages/block-library/src/breadcrumbs/edit.js
@@ -118,7 +118,8 @@ export default function BreadcrumbEdit( {
 
 	// Try to determine breadcrumb type for more accurate previews.
 	let _showTerms;
-	// For non-hierarchical post types with a parent (e.g., attachments) use ancestor-based breadcrumbs.
+	// Some non-hierarchical post types (e.g., attachments) can have parents.
+	// Use hierarchical breadcrumbs if a parent exists, otherwise use taxonomy breadcrumbs.
 	if ( ! isPostTypeHierarchical && ! post?.parent ) {
 		_showTerms = true;
 	} else if ( ! postTypeHasTaxonomies ) {
diff --git a/packages/block-library/src/breadcrumbs/index.php b/packages/block-library/src/breadcrumbs/index.php
@@ -77,35 +77,34 @@ function render_block_core_breadcrumbs( $attributes, $content, $block ) {
 		}
 
 		// For non-hierarchical post types with parents (e.g., attachments), build trail for the parent.
-		$trail_post_id     = $post_id;
-		$trail_post_type   = $post_type;
-		$trail_post_parent = $post->post_parent;
-		$parent_post       = null;
-		if ( ! is_post_type_hierarchical( $post_type ) && $post->post_parent ) {
-			$parent_post = get_post( $post->post_parent );
+		$post_parent = $post->post_parent;
+		$parent_post = null;
+		if ( ! is_post_type_hierarchical( $post_type ) && $post_parent ) {
+			$parent_post = get_post( $post_parent );
 			if ( $parent_post ) {
-				// Use parent post for the breadcrumb trail.
-				$trail_post_id     = $parent_post->ID;
-				$trail_post_type   = $parent_post->post_type;
-				$trail_post_parent = $parent_post->post_parent;
+				$post_id     = $parent_post->ID;
+				$post_type   = $parent_post->post_type;
+				$post_parent = $parent_post->post_parent;
 			}
 		}
 
 		// Determine breadcrumb type.
+		// Some non-hierarchical post types (e.g., attachments) can have parents.
+		// Use hierarchical breadcrumbs if a parent exists, otherwise use taxonomy breadcrumbs.
 		$show_terms = false;
-		if ( ! is_post_type_hierarchical( $trail_post_type ) && ! $trail_post_parent ) {
+		if ( ! is_post_type_hierarchical( $post_type ) && ! $post_parent ) {
 			$show_terms = true;
-		} elseif ( empty( get_object_taxonomies( $trail_post_type, 'objects' ) ) ) {
+		} elseif ( empty( get_object_taxonomies( $post_type, 'objects' ) ) ) {
 			$show_terms = false;
 		} else {
 			$show_terms = $attributes['prefersTaxonomy'];
 		}
 
 		// Build breadcrumb trail.
 		if ( ! $show_terms ) {
-			$breadcrumb_items = array_merge( $breadcrumb_items, block_core_breadcrumbs_get_hierarchical_post_type_breadcrumbs( $trail_post_id ) );
+			$breadcrumb_items = array_merge( $breadcrumb_items, block_core_breadcrumbs_get_hierarchical_post_type_breadcrumbs( $post_id ) );
 		} else {
-			$breadcrumb_items = array_merge( $breadcrumb_items, block_core_breadcrumbs_get_terms_breadcrumbs( $trail_post_id, $trail_post_type ) );
+			$breadcrumb_items = array_merge( $breadcrumb_items, block_core_breadcrumbs_get_terms_breadcrumbs( $post_id, $post_type ) );
 		}
 
 		// Add parent post title if applicable.
