Post heads-up notification when auto-creating monthly roundup issue#475
Merged
Conversation
The label-notifier workflow's initial-notification job listens for the 'labeled' event, but events fired by GITHUB_TOKEN inside another workflow do not trigger downstream workflows. As a result, when create-roundup-issue auto-creates the next month's issue with the Monthly Roundup label, the heads-up @-mention notification never fires (see issue #471). Post the heads-up comment directly from this workflow so the notification runs reliably for both bot-created and manually-labeled issues.
Clarify why the initial-notification job appears redundant: the normal monthly cycle is handled inline by create-roundup-issue.yml, and this job is the fallback for manually-created or off-cycle roundup issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the missing heads-up notification on auto-created Monthly Roundup issues (e.g. #471).
Root cause
label-notifier.yml'sinitial-notificationjob listens for thelabeledevent on issues. However, GitHub Actions does not chain workflows triggered byGITHUB_TOKEN— so whencreate-roundup-issue.ymlauto-creates the next month's issue with theMonthly Rounduplabel, the resultinglabeledevent is suppressed andlabel-notifier.ymlnever runs. The notification only fires when a human manually applies the label, which is why this wasn't caught earlier.Fix
Post the heads-up comment directly inside
create-roundup-issue.yml, right after the existing "update Google Doc / assign Author" comment. This bypasses the workflow-chaining limitation entirely and keepslabel-notifier.ymlworking for the manual-label path.The recipient list is hoisted into a workflow-level `env:` to make it easy to keep in sync with `label-notifier.yml`.
Test plan