Try/all pattern exporting #747
Conversation
|
And now, suddenly, all of the patterns in Twenty Twenty Five are... editable. 
It's kind of lovely really. |
| "mappings": { | ||
| "wp-content/themes": "./dev-env/themes" | ||
| }, | ||
| "config": { | ||
| "WP_UPLOAD_MAX_FILESIZE": "128M", | ||
| "WP_MEMORY_LIMIT": "256M" | ||
| "WP_MEMORY_LIMIT": "256M", | ||
| "WP_ENVIRONMENT_TYPE": "development", | ||
| "WP_DEVELOPMENT_MODE": "all" |
There was a problem hiding this comment.
It looks like this was committed accidentally.
There was a problem hiding this comment.
Actually, it wasn't an accident, though I suppose that should probably go in a separate PR.
The environment variables feel pretty necessary, when running the wp-env environment, to be running in development mode (to prevent pattern cacheing). And the mappings allows us to actually interact with the theme assets from an environment spun up from wp-env.
Both important changes I think, so I'll open up a separate PR in which to discuss the merits.
…mplified pattern export logic.
| public static function add_pattern_to_theme($pattern) | ||
| { | ||
| $patterns_dir = get_stylesheet_directory() . DIRECTORY_SEPARATOR . 'patterns' . DIRECTORY_SEPARATOR; | ||
| $pattern_file = $patterns_dir . $pattern->name . '.php'; |
There was a problem hiding this comment.
This need to be slugify with sanitize_title() to avoid special characters conversion in filename.
Actually pattern named "Étiquettes" becomes %c3%a9tiquettes.php whereas it should become etiquettes.php
|
hey @pbking . any reason why this is not merged? I'm here because I'm testing the Synced Pattern Overrides + CBT, and as soon as i press "Save changes to the theme" my synced pattern are not synced anymore. This behavior kills the reason we would use synced pattern Overrides, I don't undertand why CBT behave like this.... |
|
I don't understand why it ever made it in to begin with. I'm a strong believer that it should be removed. I don't really work on this project anymore since Automattic and I er... parted ways. You may find these projects that I work on instead helpful for your pattern work. There are bugs, but I still use them in my daily work. If anybody ever finds value in them I might continue working on them to tighten them up. https://github.com/Twenty-Bellows/synced-patterns-for-themes https://github.com/Twenty-Bellows/pattern-builder |
Still mostly an experiment but it's working pretty well; I've been using it for (not.. in.. but for) production for a bit now.
This change adds pattern management to CBT: Both for Synced and Unsynced patterns.
With this plugin loaded Any pattern (that has Inserter: true) that is in the theme's "/patterns" folder is UN-registered. It's then made available to the Site Editor, posing as a User Created pattern (which can be edited). When the user saves the pattern the pattern file is updated (instead of the database). Any User-created unsynced patterns are saved as a file when you "Save Changes to Theme". Boom. Pattern Management.
But wait there's more.
If you create SYNCED patterns then THOSE get written to the /patterns folder too. There is an additional "Synced: true" flag saved in their file. When those patterns are loaded (and CBT is activated) then the content of those patterns are copied to the database.
There's a little snippet of code that can go along with the themes exported with these patterns that allows them to continue to be loaded as synced patterns. HOWEVER it's not necessary; if CBT is inactive and the snippet is absent the patterns will just load as unsynced patterns.
The REASON that doesn't cause problems is because none of the patterns and templates that use these synced patterns actually REFERENCE them as blocks
<!-- wp:block {ref:123} /-->but instead by a pattern slug
<!-- wp:pattern {slug:SLUG} /-->When CBT loads the "synced" patterns it registers an "unsynced" pattern with the content
<!-- wp:block {ref:123} /-->.This allows you to fully manage your patterns, USE them in templates (and other patterns!) and then SAVE your theme, with all of your patterns safely packed inside.
To Test