Fixed font utilities to work with font sources as an (optional) array. #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbking
force-pushed
the
fix/font-src-array
branch
from
40ada68 to
403c547
Compare
matiasbenedetto
approved these changes
May 30, 2024
Contributor
matiasbenedetto
left a comment
matiasbenedetto
left a comment
There was a problem hiding this comment.
This is working OK. I found a bug while testing this PR: #656. As it is somewhat related but isn't caused by this PR, I'm approving it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving theme.json the
srcof font faces CAN be an array.This change always writes that value as an array and can now operate on theme.json configurations that use arrays OR strings.
Fixes #599