Don't Clobber Metadata #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
t-hamano
reviewed
May 16, 2024
Contributor
|
By the way, I submitted a core ticket proposing to be able to also retrieve the |
…tring is being built (put it before), ensure that blank lines don't follow metadata if there is no copyright information, that there is only a single blank line following copyright and css_content is correctly positioned.
t-hamano
approved these changes
May 16, 2024
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! I feel that the refactoring has made it easier to imagine the output results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving metadata to style.css a number of default values are written without considering the existing values.
This change keeps those values, copying them from the old style.css file to what is generated.
Specifically:
Copyright information
License/License URI
WordPress minimum version
This also fixes a bug where the VERSION was being wiped when updating metadata.
To Test:
Activate a theme that has things that could be changed. (Ames is a good theme to test with, it has all of the above)
Using CBT 'Edit Theme Metadata' and 'Update' without changing anything.
Note how the style.css changed. ONLY the "Tested up to" value should be different.