Skip to content

Conversation

@pbking
Copy link
Contributor

@pbking pbking commented May 9, 2024

style.css and readme.txt should be bare (having only the values defined when creating the theme), changelog should be removed (with only the first "initial release" included) for cloned themes.

To test: clone a theme, create a child theme and create a blank theme

Observe the style.css and readme.txt files and ensure that the version is as expected.

NOTE: For CLONED themes the TAGS value in the style.css is copied over. This is expected.

Fixes #613
Fixes #570

Copy link
Member

@madhusudhand madhusudhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pbking
Copy link
Contributor Author

pbking commented May 10, 2024

I misunderstood the point of #523 so returned starting version to 1.0.0 (semantic versioning).

@pbking pbking merged commit b496fc0 into trunk May 10, 2024
@pbking pbking deleted the try/reset-readme-on-clone branch May 10, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Reset the theme version number to 1.0.0 when cloning a theme Clear Changelog when cloning a theme

3 participants