Proposal: Use non-default port for wp-env #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find myself having to stop my Gutenberg environment, which uses the default port, when working on both at around the same time. This change should make it easier to have both environments running in parallel.
vcanales
changed the title
matiasbenedetto
approved these changes
May 6, 2024
Contributor
matiasbenedetto
left a comment
matiasbenedetto
left a comment
There was a problem hiding this comment.
The containers run at the specified ports. It looks good to me.
pbking
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find myself having to stop my Gutenberg environment, which uses the default port, when working on both at around the same time. This change should make it easier to have both environments running in parallel.
I realize I could choose to run a .wp-env.override.json file as well, but I think this might benefit other folks as well.