Use CORE for Font Management #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding this because tests in this PR depend on a function — wp_get_font_dir — that was introduced in 6.5
It isn't really working anyway.
vcanales
approved these changes
Mar 21, 2024
Member
vcanales
left a comment
vcanales
left a comment
There was a problem hiding this comment.
This is working well for me. LGTM.
| run: | | ||
| mysql -uroot -h127.0.0.1 -e 'SELECT version()' \ | ||
| && ./bin/install-wp-tests.sh --recreate-db wordpress_test root '' > /dev/null \ | ||
| && ./bin/install-wp-tests.sh --wp-version=trunk --recreate-db wordpress_test root '' > /dev/null \ |
Member
There was a problem hiding this comment.
Interesting that it didn't work on nightly; it worked here 420ad20
Contributor
Author
There was a problem hiding this comment.
Yes! Very strange! I didn't expect it to, I just noticed the || in the code and gave it a whirl.
It made zero sense but I ran with it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #451
Copy ACTIVATED USER FONTS to the THEME when SAVED.
REMOVE UNACTIVATED FONTS from the THEME when SAVED.
To test:
Install Fonts to Theme
/assets/fonts) and added to the theme.jsonUninstall Fonts from Theme