You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing this PR it worked for me. I copied the file's content and pasted it on a site running Create Block Theme 1.6.0...
But after 1.6.1 was released, I faced this bug again on a fresh site with Create Block Theme 1.6.1. The same steps as described in #242, but the template is now indeed exported referencing the part with spaces stripped on the theme attribute.
In this capture, I show the new site where I uploaded the recently generated theme from another site (with Create Block Theme 1.6.1).
You can see that the theme attribute is there without spaces, but the part does not render.
When testing this PR it worked for me. I copied the file's content and pasted it on a site running Create Block Theme 1.6.0...
I'm sorry, but I think I didn't test properly at the time. I just retested doing this ⬆️ and the problem persisted in 1.6.0 with the changes from the PR applied
Ok, I found out what happened. I was uploading a file named letheme (2).zip (a result of downloading multiple times) that ended up creating a folder named letheme-2 in the site, so the editor requests to wp-json/wp/v2/template-parts/letheme//header?context=edit&_locale=user were failing. Sorry for the noise
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
How to test?
Follow the steps detailed in the description of: #242
Fixes: #242